[Bug 1295127] Review Request: awscli - Universal Command Line Environment for AWS

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1295127



--- Comment #3 from Antonio Trande <anto.trande@xxxxxxxxx> ---
- Defining py2_build/py2_install macros on rhel is not need; you can use
expanded form in all builds.

- python?-packages are not defined. See how is written an example SPEC file: 
  http://fedoraproject.org/wiki/Packaging:Python#Example_common_spec_file

- See also how to avoid collisions between the python 2 and python 3 stacks

- Use macro as much as possible:

/usr/share/bash-completion/completions -->
%{_datadir}/bash-completion/completions

- ??
%if 0%{?fedora}
BuildRequires: bash-completion
%endif # Fedora

In this way, bash-completion will be installed only on Fedora and it's not
necessary for building, but as Requires package I think.

Like so 'zsh' is a Requires package because you install 'aws_zsh_completer.sh'
in '/usr/share/zsh/site-functions'.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]