[Bug 1293045] Review Request: fontopia - the console font editor

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1293045

Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
       Docs Contact|zbyszek@xxxxxxxxx           |
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |zbyszek@xxxxxxxxx
              Flags|                            |fedora-review+



--- Comment #3 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> ---
+ license is OK (GPLv3+)
+ license file is present, %license is used
+ latest version
+ builds and install OK
+ scriptlets match guidelines
+ standard macros are used

You could %exlude %{_pkgdocdir}/COPYING to avoid duplicated file (and a warning
from rpmlint).

Unfortunately you violate one significant guideline: the package uses stuff
packaged as %doc at runtime. When installed with --exludedocs, internal help is
missing and other things are broken too.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]