https://bugzilla.redhat.com/show_bug.cgi?id=1294275 --- Comment #2 from Antonio Trande <anto.trande@xxxxxxxxx> --- Hi Stuart, (In reply to Stuart Campbell from comment #1) > This is an informal review. > > rpmlint python-ivi-0.14.9-1.fc23.src.rpm > 1 packages and 0 specfiles checked; 0 errors, 0 warnings. > > Some general initial comments: > > The BuildRequires should have one package per line. This is not mandatory. http://fedoraproject.org/wiki/Packaging:Guidelines#BuildRequires_2 > > The build and install steps should make use of the %py2_build and > %py2_install commands (and similar for python3). Those macros are not available yet on EPEL6. Using expanded form is not forbidden. > > The python3 package doesn't include the python_provide info. The python3 subpackage must provide python3-example. However, as the naming guidelines mandate that the python3 subpackage be named python3-example, this will happen automatically. http://fedoraproject.org/wiki/Packaging:Python#Provides -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review