https://bugzilla.redhat.com/show_bug.cgi?id=1217957 Yanis Guenane <yguenane@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |yguenane@xxxxxxxxxx --- Comment #9 from Yanis Guenane <yguenane@xxxxxxxxxx> --- My review is yet unofficial as I am not part of the packager group. Following the Guideline for Python packaging[1], part of the spec file could be simplified - as it does exactly what those macros do. > %{__python2} setup.py build %py2_build > %{__python2} setup.py install --skip-build --root %{buildroot} %py2_install Also following on @Raphael Groner comment, what is being asked here is for the spec file to allow to build relogger for both python2 and python3 runtime. So create a new subpackage called python3-relogger for example, run %py3_build, run %py3_install and %files -n python3-relogger in addition of the traditional py2 sequences. In the community it is generally conditioned using a with_python3 global variable, set to either 1 or 0 based on the OS and the version it is built for. This allows for the package so still be build on OS version that do not come with python3. Something similar to > %if 0%{?fedora} > 12 || 0%{?rhel} > 6 > %global with_python3 1 > %endif > %if 0%{with_python3} > > %package -n python3-relogger > BuildRequires: python3-devel > > %description -n python3-relogger > .... > > %endif You would condition the same way %py3_build, %py3_install and %file -n python3-relogger [1] https://fedoraproject.org/wiki/Packaging:Python#Example_common_spec_file -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review