[Bug 1295217] Review Request: msgpuck - a MsgPack serialization library in a self-contained header file

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1295217

Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |zbyszek@xxxxxxxxx
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |zbyszek@xxxxxxxxx
              Flags|                            |fedora-review?



--- Comment #2 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> ---
Remove the "A" article from Summary, it looks better in listings without.

There's a dot not a comma in "like JSON. but fast and small".

I think you should remove the "main" package which only contains the readme and
license files, and simply include those files in both -doc and -devel. There is
no guideline for this (afaik), but in general we try to avoid unnecessary
subpackages.

Use %license for LICENSE
[https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text].

Remove the quotes from %files.

You can also remove the quotes in %install and %build: no paths will ever
contain spaces.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]