[Bug 1295115] Review Request: swift-lang - Swift Programming Language by Apple

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1295115

Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |zbyszek@xxxxxxxxx



--- Comment #15 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> ---
URLs should use https (not http) if possible. Both swift.org and github.com
support https.


You should define a macro with the common parameters to build commands:
%global buildcmd \
  -swift/utils/build-script \
  --assertions \
  --no-swift-stdlib-assertions \
  --llbuild --swiftpm \
  --xctest ... \
   --reconfigure

and then use it instead of the common part in %build, %check, %install.


%files lldb
...
%{python2_sitelib}/readline.so

This looks very wrong. swift should be be installing a file with a name of an
existing python module. It should also not be installing a binary file in a
non-arched directory.

For the other .so files: usually the versioned libraries (*.so.*) are packaged
in the library subpackage (swift-lang-lldb in this case), and the versionless
.so link is packaged in the devel subpackage (swift-lang-lldb-devel) in this
case.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]