[Bug 1293100] Review Request: tarantool - an in-memory database and Lua application server

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1293100

Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |zbyszek@xxxxxxxxx



--- Comment #13 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> ---
%global __strip /bin/true might work.

Don't repeat the package name in Summary. Also don't use the article, it looks
bad in listings:

Summary: In-memory database and Lua application server

Remove Vendor tag.

Why do you need explicit requirements on readline and other libraries; aren't
the automatically generated dependencies enough?

Development subpackage should be called devel, that's the Fedora standard.

tarantool should requires te same version of tarantool-common:
Requires: %{name}-common = %{version}-%{release}
Most likely you do not need the Requires on tarantool in tarantool-common.

%if 1%{?systemd} → this condition is always true. Maybe you meant %if
0%{?systemd}?

What's with the quotes around filenames in %files?

Scripts in %post should never fail, add || : everywhere.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]