https://bugzilla.redhat.com/show_bug.cgi?id=1295549 --- Comment #8 from Rex Dieter <rdieter@xxxxxxxxxxxx> --- An initial course review... rpmlint clean naming: ok macros: ok sources: n/a I'll take your word on the stripping process. will verify more in a later review pass 1. license: tag needs work (per comment #7) macros: ok (mostly) 2. SHOULD probably use instead: %files examples %{_qt5_examplesdir}/ scriptlets: ok 3. SHOULD add appropriate Provides: tags for bundled code, https://spot.fedorapeople.org/chromium.spec probably includes a reasonable reference for a starting point. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review