Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: xulrunner - XUL Runner https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=244374 caillon@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gecko-maint@xxxxxxxxxx ------- Additional Comments From caillon@xxxxxxxxxx 2007-06-19 00:08 EST ------- 1. MUST provide gecko-devel, gecko-libs and gecko-debuginfo 2. MUST pull in all relevant patches from the rawhide version of Firefox that haven't been applied upstream yet (and I know there are a few). We must not regress here. The pango patches are probably safe to drop as they have been replaced with a different architecture. Many other fixes should have been upstreamed. But there are a handful that probably still need to make it in. 3. bsmedberg mentioned that gtkmozembed is going to be in a separate source tarball. We should make that happen in conjunction with this, because most dependent things really just want that. It has a more stable ABI/API. 4. We need to build with -rpath. Again, see rawhide. 5. pragma visibility works on all platforms now, so that can be removed. It's late and I have other stuff I want to get to, but please please PLEASE do not regress from current trunk. I'll try to take a look in the morning. P.S. you guys suck for not making sure I was aware of this :-P -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review