Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: subcommander - Graphical UI for subversion https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=243763 bugzilla@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Product|Fedora Extras |Fedora panemade@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From panemade@xxxxxxxxx 2007-06-18 23:50 EST ------- Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and for RPMs. + source files match upstream. d32fa91546151347707f6c1a553cbcec Subcommander-1.2.2.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is small so no need of -doc subpackage. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no static libraries. + no .pc files are present. + no -devel subpackage exists. + no .la files. + no translations available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + no scriptlets used. + Desktop files installed correctly. + Requires: libapr-1.so.0 libaprutil-1.so.0 libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.4) libcrypto.so.6 libdb-4.5.so libdl.so.2 libexpat.so.0 libgcc_s.so.1 libgcc_s.so.1(GCC_3.0) libgcc_s.so.1(GLIBC_2.0) liblber-2.3.so.0 libldap-2.3.so.0 libm.so.6 libneon.so.25 libpthread.so.0 libqt-mt.so.3 libstdc++.so.6 libstdc++.so.6(CXXABI_1.3) libstdc++.so.6(GLIBCXX_3.4) libstdc++.so.6(GLIBCXX_3.4.5) libsvn_client-1.so.0 libsvn_delta-1.so.0 libsvn_diff-1.so.0 libsvn_fs-1.so.0 libsvn_fs_fs-1.so.0 libsvn_ra-1.so.0 libsvn_ra_dav-1.so.0 libsvn_ra_local-1.so.0 libsvn_ra_svn-1.so.0 libsvn_repos-1.so.0 libsvn_subr-1.so.0 libsvn_wc-1.so.0 libz.so.1 rtld(GNU_HASH) + GUI App. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review