[Bug 1295259] Review Request: php-di-symfony2-bridge - PHP-DI integration with Symfony 2

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1295259

Remi Collet <fedora@xxxxxxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-review+



--- Comment #6 from Remi Collet <fedora@xxxxxxxxxxxxxxxxx> ---
composer.json looks strange, "tests" are in the "require" part, not in the
"require-dev" section...

[x]: Package is named according to the Package Naming Guidelines.
    Ok, php-di-symfony2-bridge is better than php-php-di-symfony2-bridge

[x]: %check is present and all tests pass.
    Ok with PHPUnit 4.8 and 5.1
    Ok with PHP 5.6 and 7.0

No blocker.

=== APPROVED ===

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]