https://bugzilla.redhat.com/show_bug.cgi?id=1265685 Christopher Meng <i@xxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |i@xxxxxxxx --- Comment #20 from Christopher Meng <i@xxxxxxxx> --- (In reply to Ranjan Maitra from comment #16) > > * Useless define: %define ver 0.8 > > I don't understand this one. Please don't make use of any useless macros, you can also define a macro 'nam' and value it like Name: %{nam} and so on. However, these are just useless, keeping your spec simple but powerful is the key that sponsor will basically notice your work. Keep it in a whirl will make people think if you really know how to package. There is no luck for people don't understand suggestions, especially useful ones. Writing specs is not programming, you don't need to reinvent any wheels to demonstrate that you are skilled (And from comments I don't think you are skilled). ------------------------------- My review ------------------------------- 1. Summary: A generic message filter library and command-line tools I guess you are not an native English speaker, please correct the sentence. Hence please revise %description. 2. Requires: sylpheed This is often superfluous. Generally, RPM will pick up it automatically. 3. %__make %_smp_mflags Please keep in one style: %{XYZ} instead of %XYZ Also try using %{make_build} if you want. 4. %changelog * Fri Dec 11 2015 Ranjan Maitra <X> 0.8-4 - initial rebuild for Fedor (to include the devel file) * Wed Dec 02 2015 Ranjan Maitra <X> 0.8-3 - initial rebuild for Fedor (to make dependent on sylpheed, as per comments from Ralf Corsepius <Y>) * Tue Dec 01 2015 Ranjan Maitra <X> 0.8-2 - initial rebuild for Fedora (to take care of comments from Ralf Corsepius <Y>) * Tue Sep 22 2015 Ranjan Maitra <X> 0.8-1 - initial build for Fedora i. Please do not invoke any other people's email address unless there is a strong reason you must do. For such simple anti spam trick, email address collector will easily crack it. ii. Please leave a blank line per entry. iii. Please FIX the language, like 'Fedor'. 5. Check deps in -devel package to see if any explicit requires are needed. (Like, you build package with sqlite-devel and glib2-devel and while installing sylfilter-devel, RPM won't pick up sqlite-devel or glib2-devel) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review