[Bug 1290513] Review Request: playonlinux - Front-end application for the wine

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1290513



--- Comment #11 from Neal Gompa <ngompa13@xxxxxxxxx> ---
Jiri,

Since it appears you're the author of the Makefile being used, could you make
it compatible with our macros %make_build and %make_install?

%make_build expands out to: make %{?_smp_mflags}

%make_install expands out to: make install DESTDIR=%{?buildroot}

Most likely, %make_build will work fine, since the "all" target in your
makefile goes to "build".

However, your install target doesn't handle DESTDIR, it seems. If your makefile
handled it correctly, you could use %make_install PREFIX=%{_prefix} and it
would work, because it would internally combine DESTDIR (set to %{buildroot})
with PREFIX to create the install path. Or it could default to /usr as the
prefix and not require it to be set unless otherwise being changed.

Also, why are Python scripts in the datadir being set with the executable bit?
Stuff there shouldn't generally be executable.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]