https://bugzilla.redhat.com/show_bug.cgi?id=1290530 --- Comment #1 from Martin Ueding <von.fedora@xxxxxxxxxxxxxxxx> --- Hi, I am new to Fedora packaging and should do a couple formal reviews to show that I have some idea of the packaging guidelines. Please take my comments with a grain of salt as I am not yet anyone who has to decide anything. # CMake The `cmake` invocation you do is passed a couple flags but not all of them. As far as I have understood you can just use `%cmake ..` and get all the flags needed. The two `export` statements should not be needed either then as the `CXXFLAGS` are happily passed along. On the command line a `rpm -E '%cmake'` tell me that there is for instance CXXFLAGS="${CXXFLAGS:--O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -m64 -mtune=generic}" ; export CXXFLAGS ; in there. So it does give you the flags you want without having to do this manually. # make If you do the above you do not need to specify `VERBOSE=1` to `make` as `cmake` will bake that into the `Makefile` directly. # make install In the package Eduardo just approved for me I had `DESTDIR=%{buildroot}`. As far as I know the two variables are just the same. # licensedir I am not really sure what that line is for, could you please tell me? ---- I will have to go over that with the full checklist again tomorrow. Martin -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review