[Bug 1295115] Review Request: swift-lang - Swift Programming Language by Apple

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1295115



--- Comment #13 from Michael Schwendt <bugs.michael@xxxxxxx> ---
> Release is usually just an integer (i.e. 1 instead of 0.1)

Generally, that's not true, since you seem to forget the pre-release
guidelines:

 
https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Pre-Release_packages

And if this package really is a snapshot, there are specific guidelines for
snapshots, too:

  https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Snapshot_packages


> %setup -q -T -D -a 1
> %setup -q -T -D -a 2
> %setup -q -T -D -a 3
> %setup -q -T -D -a 4
> %setup -q -T -D -a 5
> %setup -q -T -D -a 6
> %setup -q -T -D -a 7
> %setup -q -T -D -a 8
> %setup -q -T -D -a 9
> %setup -q -T -D -a 10

Isn't it possibly anymore to specify -a multiple times in a single %setup
invocation?


> %post -p /sbin/ldconfig
> 
> %postun -p /sbin/ldconfig

Why is ldconfig run for the base package, although the package does not store
any libs in runtime linker's search path?


> %files lldb
> %{_libdir}/liblldb.so*

This subpackage wants to run ldconfig in its scriptlets.


> %{_libdir}/swift/pm/*

Lots of so-called "unowned directories" created by this package. Kindly review
the following pages

 
https://fedoraproject.org/wiki/Packaging:Guidelines#File_and_Directory_Ownership
  https://fedoraproject.org/wiki/Packaging:UnownedDirectories

and carefully examine directory ownership of all [sub-]packages.


> %doc %{_mandir}/man1/swift.1.gz
> %doc %{_datarootdir}/doc/swift/*

%_datarootdir/doc = %_datadir/doc = %_docdir

And both %_docdir as well as %_mandir is a path where files implicitly are
marked as %doc, because it's in the %__docdir_path list. See: rpm -E
%__docdir_path

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]