[Bug 1295710] Review Request: wml - WML is a free and extensible Webdesigner's off-line HTML generation toolkit for Unix

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1295710

Petr Pisar <ppisar@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ppisar@xxxxxxxxxx



--- Comment #1 from Petr Pisar <ppisar@xxxxxxxxxx> ---
The Perl dependencies are wrong. Perl language structures code into Perl
modules and the dependencies in the spec files must be specified on them. Not
on the packages. For example if the code used "GD" module, the spec file should
read "perl(GD)", not "perl-GD".

Also you are missing many of them. For example, cmake/pod2man-wrapper.pl is
executed at build time, there should be BuildRequires on perl(File::Copy),
perl(File::Temp), perl(Getopt::Long), perl(strict), perl(warnings).

I didn't examined the build process thoroughly, but I think build-time
dependency on perl(GD) (no perl-GD) is not needed because none of the three
files that use it does look like being executed then building the package.
Maybe they could if you run tests. It would be good to run tests in the %check
section.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]