[Bug 1295685] Review Request: python-bcrypt - Modern password hashing for your software and your servers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1295685

Parag AN(पराग) <panemade@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |panemade@xxxxxxxxx
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |panemade@xxxxxxxxx



--- Comment #3 from Parag AN(पराग) <panemade@xxxxxxxxx> ---
looks like a conflict with py-bcrypt package due to same installation file
/usr/lib64/python2.7/site-packages/bcrypt/_bcrypt.so

I think we can add conflicts in this package to py-bcrypt.

Then there are couple of issues
1) Spec file according to URL is the same as in SRPM.
     Note: Spec file as given by url is not the same as in SRPM (see
     attached diff).
Diff spec file in url and in SRPM
---------------------------------
--- /home/parag/1295685-python-bcrypt/srpm/python-bcrypt.spec   2016-01-05
21:08:50.067867587 +0530
+++ /home/parag/1295685-python-bcrypt/srpm-unpacked/python-bcrypt.spec 
2016-01-05 12:48:24.000000000 +0530
@@ -78,5 +78,4 @@
 %{python3_sitearch}/%{modname}-%{version}*

-
 %changelog
 * Tue Jan 05 2016 Pierre-Yves Chibon <pingou@xxxxxxxxxxxx> - 2.0.0-1


2) rpmlint output as
python2-bcrypt.x86_64: W: unexpanded-macro Obsoletes python-%{module} <
2.0.0-1.fc24 %{module}
python2-bcrypt.x86_64: W: unexpanded-macro Obsoletes python-%{module}(x86-64) <
2.0.0-1.fc24 %{module}
python2-bcrypt.x86_64: W: unexpanded-macro Provides python-%{module} =
2.0.0-1.fc24 %{module}
python2-bcrypt.x86_64: W: unexpanded-macro Provides python-%{module}(x86-64) =
2.0.0-1.fc24 %{module}
python2-bcrypt.x86_64: E: non-standard-executable-perm
/usr/lib64/python2.7/site-packages/bcrypt/_bcrypt.so 775
python3-bcrypt.x86_64: E: non-standard-executable-perm
/usr/lib64/python3.5/site-packages/bcrypt/_bcrypt.cpython-35m-x86_64-linux-gnu.so
775
python-bcrypt.src:64: W: macro-in-comment %check
python-bcrypt.src:65: W: macro-in-comment %{__python2}
python-bcrypt.src:66: W: macro-in-comment %{__python3}
4 packages and 0 specfiles checked; 2 errors, 7 warnings.

==>  some places modname used and at some places module is used. Please fix
this. Also fix the permission issue by adding following at end of %install
find %{buildroot}%{python2_sitearch} -name '*.so' -exec chmod 755 {} ';'
find %{buildroot}%{python3_sitearch} -name '*.so' -exec chmod 755 {} ';'


3) License should be "ASL 2.0 and Public Domain".

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]