[Bug 1295258] Review Request: php-di - The dependency injection container for humans

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1295258



--- Comment #5 from Remi Collet <fedora@xxxxxxxxxxxxxxxxx> ---
[x]: Package is named according to the Package Naming Guidelines.
    Per Guidelines should be php-php-di
    But I agree, php-di is simpler / cleaner

[x]: %check is present and all tests pass.
    OK with PHPUnit 4.8 and 5.1
    OK with PHP 5.6
    KO with PHP 7.0

There was 1 error:

1)
DI\Test\IntegrationTest\Definitions\ObjectDefinitionTest::test_object_without_autowiring
DI\Definition\Exception\DefinitionException: Entry "object" cannot be resolved:
The parameter "ar_flags" of __construct() has no type defined or guessable. It
has a default value, but the default value can't be read through Reflection
because it is a PHP internal class.
Full definition:
Object (
    class = ArrayObject
    scope = singleton
    lazy = false
    __construct(
        $array = array (
)
        $ar_flags = #UNDEFINED#
        $iterator_class = #UNDEFINED#
    )
)

Obviously failure with PHP 7 is not a blocker, so only FYI.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]