[Bug 1294467] Review Request: pidgin-window-merge - plugin for single window mode

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1294467



--- Comment #2 from Jan Grulich <jgrulich@xxxxxxxxxx> ---
1) Rpmlint says:
pidgin-window-merge.src:15: W: mixed-use-of-spaces-and-tabs (spaces: line 15,
tab: line 1)

Also there is unnecessary tab at the end of line 10.

2) In %prep you can just use
%setup -qn %{pname}-%{version} -a 1

Seems to work for me, you just need to adjust installation of that appdata file
in %install section. You could also include the appdata file as an xml file
without making a tarball from it.

3) Doesn't build → missing "BuildRequires: libappstream-glib"

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]