[Bug 1290513] Review Request: playonlinux - Front-end application for the wine

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1290513

Neal Gompa <ngompa13@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ngompa13@xxxxxxxxx



--- Comment #8 from Neal Gompa <ngompa13@xxxxxxxxx> ---
@Jiri, could you please change your python Requires to "python2"? It makes it
more clear that it has a hard requirement on Python 2, especially once "python"
is switched to Python 3 in the future.

Additionally, please use the macros in the %install phase.

For example, "/usr" would be replaced with %{_prefix}, "/usr/share" would be
replaced with %{_datadir}, and so on.

Also, unless you're targeting older than EL7, you can choose to use %autosetup
or %setup and %autopatch.

For example, with %autosetup:
%autosetup -n %{BUILD_DIR} -p1

Or, with %setup and %autopatch:
%setup -qn %{BUILD_DIR}
%autopatch -p1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]