https://bugzilla.redhat.com/show_bug.cgi?id=1295144 --- Comment #12 from gil cattaneo <puntogil@xxxxxxxxx> --- (In reply to Michael Schwendt from comment #11) > Let me recommend slowing down with the review a bit. > > > > Please, remove: > > %define checkout 20140302git > > During review, while it is good to point at the guidelines, in this case the > guidelines don't forbid %define in any way. Just like several other parts of > the guidelines, they aim at educating packagers about a pitfall related to > %define. There are hundreds of packages that build correctly using %define > for global definitions in the spec file. > Please, read this thread: https://lists.fedoraproject.org/archives/list/devel%40lists.fedoraproject.org/thread/AS35NKZSAWRIKY77IUYOVNFAT6AJQVAU/#GW7VY3RY76ZUH6X72FLOOEDCHURKWWI4 "%define" should be replaced, in each case (rare exceptions) by "%global" > > If the build framework, such as Makefiles that contain hardcoded paths, > doesn't accept any RPM spec file macros given to a configure script, it > would also not make any sense to use the same macros anywhere in the spec > file. You could hardcode the same paths in the spec file. > > However, if the build process can be configured to accept values such as > %_libdir or %_datadir, it is usually better to use such macros everywhere, > so if Fedora changed some locations globally, the package would change too > during a mass-rebuild already (and would not need to be modified by the > packager). > > > > must be > > Release: 0.1.%{checkout}%{?dist} > > Why that? There is a 0.3.0 release tarball at > https://bitbucket.org/raymonad/xss-lock/downloads already, dated > 2013-11-04, so a git checkout made on 20140302 is a post-release snapshot. I see, comment#10 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review