[Bug 1295055] Review Request: python-flake8-import-order - Flake8 plugin for checking order of imports in Python code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1295055



--- Comment #5 from Ville Skyttä <ville.skytta@xxxxxx> ---
Thanks for the review.

License file inclusion already reported upstream:
https://github.com/public/flake8-import-order/pull/52

Rest of the license stuff reported as well, ASL 2.0 is almost certainly a bug:
https://github.com/public/flake8-import-order/issues/55
(...and __about__.py doesn't contain anything copyrightable anyway I think.)

rm -rf $RPM_BUILD_ROOT is not unnecessary:
https://fedorahosted.org/rpmdevtools/ticket/25
https://bugzilla.redhat.com/show_bug.cgi?id=807857

You mentioned the findings being non-blocking but the fedora-review flag is
still set to "?", was that on purpose or should it have been set to "+"
already?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]