[Bug 1247442] Review Request: emacs-yaml-mode - major mode to edit YAML file for emacs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1247442



--- Comment #5 from gil cattaneo <puntogil@xxxxxxxxx> ---
Issues:
[!]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/share/emacs/site-lisp
     /yaml-mode

[!]: Uses parallel make %{?_smp_mflags} macro.

[!]: Packages should try to preserve timestamps of original installed
     files.
in makefile INSTALL constant should be /usr/bin/install -c -pm 444

install -m 644 %SOURCE1 %{buildroot}%{_emacs_sitestartdir}
should be 
install -pm 644 %SOURCE1 %{buildroot}%{_emacs_sitestartdir}

NON blocking issues:
[!]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[!]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[!]: Package does not include license text files separate from upstream.
Please, ask to upstream to include copy of the license in source directory
structure
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#License_Text

emacs-yaml-mode.noarch: E: incorrect-fsf-address
/usr/share/emacs/site-lisp/yaml-mode/yaml-mode.el
Please, report the problem to upstream
https://fedoraproject.org/wiki/Common_Rpmlint_issues#incorrect-fsf-address

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]