https://bugzilla.redhat.com/show_bug.cgi?id=1293049 Rex Dieter <rdieter@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mattia.verga@xxxxxxxxxx Flags| |needinfo?(mattia.verga@tisc | |ali.it) --- Comment #2 from Rex Dieter <rdieter@xxxxxxxxxxxx> --- naming: ok license: ok scriptlets: ok Arches: NOT ok. Looks like fpc has ExclusiveArch: %{arm} %{ix86} x86_64 ppc ppc64 and lazaras: ExcludeArch: s390 s390x I'd guess those should match closer, but in the least the .spec comment is inaccurate: # fpc and lazarus are not working on s390, ppc and aarch64 1. MUST: either clarify this comment or adjust to match fpc's ExclusiveArch: %{arm} %{ix86} x86_64 ppc ppc64 sources: NOT ok, not verifiable 2. MUST give better instructions to create reproducible sources or justify why not using upstream tarball source, http://sourceforge.net/projects/libpasastro/files/version%201.0/libpasastro-1.0-src.tar.xz/download 3. SHOULD replace fragile/manual creation of library soname links: #ln -fs %{_libdir}/libpasplan404.so.%{sover}.0 %{buildroot}/%{_libdir}/libpasplan404.so.%{sover} #ln -fs %{_libdir}/libpasgetdss.so.%{sover}.0 %{buildroot}/%{_libdir}/libpasgetdss.so.%{sover} #ln -fs %{_libdir}/libpaswcs.so.%{sover}.0 %{buildroot}/%{_libdir}/libpaswcs.so.%{sover} with: /sbin/ldconfig -n %{buildroot}%{_libdir} macros: NOT ok 4. MUST use standard $RPM_OPT_FLAGS/%{optflags}, currently uses hard-coded mixture of "-O3 -fPIC -g" and "-fPIC -g" -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review