https://bugzilla.redhat.com/show_bug.cgi?id=1295009 Bug ID: 1295009 Summary: Review Request: erlang-p1_zlib - Native zlib driver for Erlang Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@xxxxxxxxxxxxxxxxx Reporter: rbarlow@xxxxxxxxxx QA Contact: extras-qa@xxxxxxxxxxxxxxxxx CC: package-review@xxxxxxxxxxxxxxxxxxxxxxx Spec URL: https://rbarlow.fedorapeople.org/erlang-p1_zlib.spec SRPM URL: https://rbarlow.fedorapeople.org/erlang-p1_zlib-0-1.20150223gite3d4222b.fc24.src.rpm Description: A native zlib driver for Erlang, used by ejabberd. Fedora Account System Username: rbarlow Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=12360294 There are a few rpmlint warnings. I'll respond to them inline here: erlang-p1_zlib.x86_64: W: unstripped-binary-or-object /usr/lib64/erlang/lib/p1_zlib-0/priv/lib/ezlib_drv.so It seems to be Fedora Erlang packaging convention to leave the debug symbols in Erlang packages: https://fedoraproject.org/wiki/User:Peter/Erlang_Packaging_Guidelines erlang-p1_zlib.x86_64: W: no-soname /usr/lib64/erlang/lib/p1_zlib-0/priv/lib/ezlib_drv.so This seems to be a result of how Rebar builds these libraries. I think we can ignore it. erlang-p1_zlib.x86_64: W: undefined-non-weak-symbol /usr/lib64/erlang/lib/p1_zlib-0/priv/lib/ezlib_drv.so set_port_control_flags erlang-p1_zlib.x86_64: W: undefined-non-weak-symbol /usr/lib64/erlang/lib/p1_zlib-0/priv/lib/ezlib_drv.so driver_freeerlang-p1_zlib.x86_64: W: undefined-non-weak-symbol /usr/lib64/erlang/lib/p1_zlib-0/priv/lib/ezlib_drv.so driver_alloc_binary erlang-p1_zlib.x86_64: W: undefined-non-weak-symbol /usr/lib64/erlang/lib/p1_zlib-0/priv/lib/ezlib_drv.so driver_alloc erlang-p1_zlib.x86_64: W: undefined-non-weak-symbol /usr/lib64/erlang/lib/p1_zlib-0/priv/lib/ezlib_drv.so driver_realloc_binary All of these happen to other Erlang packages in Fedora as well. It seems that Erlang's runtime causes the correct linking to happen. For example, I also see this on erlang-crypto's shared objects, as well as erlang-jiffy's. I think we can safely ignore these warnings. The package review for erlang-jiffy did not even mention this warning: https://bugzilla.redhat.com/show_bug.cgi?id=1074982 erlang-p1_zlib.x86_64: W: no-documentation The upstream package does not have documentation. 1 packages and 0 specfiles checked; 0 errors, 8 warnings. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review