[Bug 1294704] Review Request: python3-setuptools - Easily build and distribute Python packages

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1294704

Ville Skyttä <ville.skytta@xxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #7 from Ville Skyttä <ville.skytta@xxxxxx> ---
(In reply to Orion Poplawski from comment #5)
> (In reply to Ville Skyttä from comment #4)
> > Summary and %description should say "Python 3" because this is Python 3 only.
> >
> > Summary and %description for the binary package should probably say "Python
> > %{python3_version}" instead of "Python 3".
> 
> The name of the package "python3X-setuptools" will be displayed next to
> summaries and description

Really, everywhere?

> and I think makes this point.

By that argument you could leave the words python and setuptools out of the
summary and description as well. It wouldn't be a good idea to do that either,
just like it is not a good idea to knowingly leave inaccurate and possibly
misleading versioning information there that would be very easy to fix. I won't
block the review because of this, but I suggest you reconsider.

> > Rest of the docs would be better installed as "%doc docs/*" to avoid one
> > unnecessary dir.
>
> Fixed.

Makefile and conf.py in docs don't seem useful, I suggest removing them before
the first build.

Accepted.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]