https://bugzilla.redhat.com/show_bug.cgi?id=1294359 Lubomir Rintel <lkundrak@xxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |lkundrak@xxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |lrintel@xxxxxxxxxx Flags| |fedora-review+ --- Comment #3 from Lubomir Rintel <lkundrak@xxxxx> --- * Named correctly * Correclty versioned * Using latest version * Upstream sources match * License tag okay * License good for Fedora * Builds fine in mock * SPEC file clean and legible APPROVED A few notes: 0.) Doesn't seem to build for me locally (f23 with updated cmake): > no theme named 'alabaster' found (missing theme.conf?) Maybe you may want to depend on python-sphinx-alabaster or whatever provides the theme, since you're explicitly using it? It could be that it's dragged into the koji buildroot by dumb luck. 1.) The perl subpackage should probably provide perl(smartcols) = NVR (since it's not generated automatically as the package doesn't use a pure perl bootstrap wrapper). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review