https://bugzilla.redhat.com/show_bug.cgi?id=1293735 --- Comment #8 from MartinKG <mgansser@xxxxxxxx> --- (In reply to Dmitry Mikhirev from comment #6) > An unofficial review. > > Need to be fixed: > > * Error opening pdf file: cannot find boomagamerger. done > * Cups backend and filter directories are > %{_prefix}/lib/cups/{backend,filter}, not %{_libdir}/cups/{backend,filter}. done > * Directories under %{_datadir}/icons/hicolor must not be owned by this > package. done > * %post and %preun scripts are inconsistent: > > %post > # Install the printer to cups backends > if [ $1 = 1 ]; then > sh %{_datadir}/%{name}/scripts/installPrinter.sh > fi > > %preun > # Uninstall the printer > lpadmin -x "Boomaga" > > The printer will be removed on package update. Use 'if [ $1 = 0 ]' in %preun. done rpm package update: Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/boomaga.spec SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/boomaga-0.7.1-3.git8ca78b2.fc23.src.rpm rpmlint boomaga.spec ../SRPMS/boomaga-0.7.1-3.git8ca78b2.fc23.src.rpm ../RPMS/x86_64/boomaga-* boomaga.spec:59: E: hardcoded-library-path in %{_prefix}/lib/cups/backend boomaga.spec:60: E: hardcoded-library-path in %{_prefix}/lib/cups/filter boomaga.spec:119: E: hardcoded-library-path in %{_prefix}/lib/cups boomaga.spec:120: E: hardcoded-library-path in %{_prefix}/lib/cups/backend boomaga.spec:122: E: hardcoded-library-path in %{_prefix}/lib/cups/backend/%{name} boomaga.spec:125: E: hardcoded-library-path in %{_prefix}/lib/cups/filter boomaga.spec:126: E: hardcoded-library-path in %{_prefix}/lib/cups/filter/boomaga_pstopdf boomaga.src:59: E: hardcoded-library-path in %{_prefix}/lib/cups/backend boomaga.src:60: E: hardcoded-library-path in %{_prefix}/lib/cups/filter boomaga.src:119: E: hardcoded-library-path in %{_prefix}/lib/cups boomaga.src:120: E: hardcoded-library-path in %{_prefix}/lib/cups/backend boomaga.src:122: E: hardcoded-library-path in %{_prefix}/lib/cups/backend/%{name} boomaga.src:125: E: hardcoded-library-path in %{_prefix}/lib/cups/filter boomaga.src:126: E: hardcoded-library-path in %{_prefix}/lib/cups/filter/boomaga_pstopdf boomaga.x86_64: W: no-manual-page-for-binary boomagamerger 3 packages and 1 specfiles checked; 14 errors, 1 warnings. %changelog * Sat Dec 26 2015 Martin Gansser <martinkg@xxxxxxxxxxxxxxxxx> - 0.7.1-3.git8ca78b2 - Follow https://fedoraproject.org/wiki/Packaging:SourceURL - corrected cups backend and filter directories - take ownership of unowned directory %%{_datadir}/icons/hicolor - use if condition in %%preun script - linked missing %%{_bindir}/boomagamerger -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review