[Bug 1279112] Review Request: kissfft - Fast Fourier Transform library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1279112

Antonio Trande <anto.trande@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |anto.trande@xxxxxxxxx



--- Comment #2 from Antonio Trande <anto.trande@xxxxxxxxx> ---
If you just need to package static libs and header files, I think it's better
naming this package 'kissfft-static' and providing header files separately in
'kissfft-devel'.

- These lines are redundant:

>%dir %{_includedir}/%{name}/
>%{_includedir}/%{name}/kfc.h
>%{_includedir}/%{name}/kiss_fft.h
>%{_includedir}/%{name}/kiss_fftnd.h
>%{_includedir}/%{name}/kiss_fftndr.h
>%{_includedir}/%{name}/kissfft.hh
>%{_includedir}/%{name}/kiss_fftr.h

You may use only:

%{_includedir}/%{name}/

- Why 'numpy' and 'Python2' among BR packages?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]