[Bug 1291933] Review Request: nodejs-mdurl - URL utilities for markdown-it

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1291933



--- Comment #5 from Tom Hughes <tom@xxxxxxxxxx> ---
Sorry, I think I missed that you had replied on this before...

I think
https://github.com/nodejs/node/blob/913addbff5481567262c387cef9594f809e4ef83/lib/url.js
is roughly the version it was based on although as you say quite a bit has been
cut out or changed.

It's not really a copylib, because that implies that upstream had an intention
that it would be copied, it's really just a fork.

I agree that bundled(nodejs) is not very useful, but the current guidelines
don't really offer any guidance on when something is different enough to become
a fork rather than bundling :-( I myself wound up adding a probably not very
helpful bundled(boost) to a package because it had two files from the upstream
boost repo that aren't in the boost releases.

We've had similar problems in the past, mostly with assert.deepequal, which
exists in about a zillion hacked about versions in the npm repository:

https://fedorahosted.org/fpc/ticket/264
https://fedorahosted.org/fpc/ticket/272
https://fedorahosted.org/fpc/ticket/297

Obviously those were all resolved under the old bundling rules.

There was apparently some talk then about special rules for "fragments" like
this but nothing ever came of it.

All those were granted exceptions, with no requirement to add a provide, so
that seems like the logical conclusion here - just not sure if we should be
getting FPC to approve that under the new rules...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]