[Bug 1244196] Review Request: qt5-qtwebengine - Qt5 - QtWebEngine components

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1244196



--- Comment #22 from Kevin Kofler <kevin@xxxxxxxxxxxxxxxx> ---
Created attachment 1108190
  --> https://bugzilla.redhat.com/attachment.cgi?id=1108190&action=edit
qtwebengine-opensource-src-5.6.0-beta-no-sse2.patch

The attached (not yet tested in any way) patch should make QtWebEngine run on
non-SSE2 x86 CPUs.

The patch is a cumulative (forward-ported) revert of upstream reviews
187423002, 511773002 (parts relevant to QtWebEngine only), 516543004,
1152053004 and 1161853008, along with some custom fixes (for example, the
third-party qcms supports runtime detection of SSE2, my patch should make this
work instead of just disabling SSE2 support entirely as Chromium was doing
before they started requiring SSE2).

If you think this patch is too large, I can do a version that does not readd
the removed (no longer supported by upstream) MMX- and SSE(1)-optimized
routines in "media" (those where an SSE2 version exists), always falling back
to the plain C ones for non-SSE2 instead. (The patch as it is now restores the
full runtime detection, which is IMHO nicer.)

The current QtWebEngine only uses gyp, but I tried to also fix the gn setup
because I guess it will be used in the future. I did not find the place where
gn sets the -msse2 -mfpmath=sse -mmmx flags though, so that will need to be
addressed separately when needed.

For those who care about the original Chromium, you will also want to revert
the remaining parts of review 511773002 and the review 296663002. I cannot do
this in this patch because QtWebEngine does not ship those files at all.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]