[Bug 1074595] Review Request: systeminfo - simple utility for viewing HW

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1074595



--- Comment #4 from Ranjan Maitra <itsme_410@xxxxxxxxx> ---
Please update to a supported Fedora version. Also update changelog and the
version number.

THere are many errors and issues. 

1) If you are packaging python2 library or tools then your spec file should use
%{__python2} macros only. See
https://fedoraproject.org/wiki/Packaging:Python#Macros

2) Its always a good practice to increase the release number when you provide
updated package here. That will help what has changed since your last package
update to new package update.

3) Note that python packaging guidelines have changed (See
https://fedoraproject.org/wiki/Packaging:Python#Example_common_spec_file). You
should change %build and %install to

%build
%py2_build

%install
py2_install

This should have the exact same effect, but is standard and more concise.

4) Please run fedora-review tool and go through the output: it will catch the
same errors and issues for you and thus make review quicker than a
back-and-forth.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]