https://bugzilla.redhat.com/show_bug.cgi?id=1234210 Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #37 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- Yep, looks good. Looking at %description again, the last paragraph is now obsolete, pypdf2 has been packaged. - license is OK (BSD), license tag matches code - license file is present, %license is used - latest version - package name follows the guidelines - new python packaging template is used - builds and install OK - no scriptlets necessary or present - provides and requires are OK rpmlint: pdf-stapler.noarch: W: spelling-error %description -l en_US opensource -> open source, open-source, outsource pdf-stapler.noarch: W: spelling-error %description -l en_US commandline -> command line, command-line, commandment pdf-stapler.noarch: W: spelling-error %description -l en_US pypdf -> PDF pdf-stapler.noarch: W: spelling-error %description -l en_US refactored -> re factored, re-factored, factored pdf-stapler.noarch: W: spelling-error %description -l en_US pyPdf -> PDF pdf-stapler.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/staplelib/stapler.py 644 /usr/bin/env pdf-stapler.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/staplelib/tests.py 644 /usr/bin/env pdf-stapler.noarch: W: no-manual-page-for-binary pdf-stapler pdf-stapler.src: W: spelling-error %description -l en_US opensource -> open source, open-source, outsource pdf-stapler.src: W: spelling-error %description -l en_US commandline -> command line, command-line, commandment pdf-stapler.src: W: spelling-error %description -l en_US pypdf -> PDF pdf-stapler.src: W: spelling-error %description -l en_US refactored -> re factored, re-factored, factored pdf-stapler.src: W: spelling-error %description -l en_US pyPdf -> PDF Those can be ignored. pdf-stapler.src:68: W: macro-in-%changelog %{__python} pdf-stapler.src:68: W: macro-in-%changelog %{__python_macros} Please fix those by doubling the macro sign in comments: %%{_python}, etc. rpm recently warns about this during build and it is very annoying. The guidelines say that you need to provide python-<modulename> and python2-<modulename>. See https://fedoraproject.org/wiki/Packaging:Python#Provides. I'm not sure that those are very meaningful in this case, but it doesn't harm to add: Provides: python2-staplelib = %{version}-%{release} %{?python_provide:%python_provide python2-%{srcname}} Only trivial issues remain, please fix those up when uploading the package. Package is APPROVED. We'll also need to finish the sponsorship process, before you are able to upload the package. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review