Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: astyle - Source code formatter https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=207896 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2007-06-18 09:39 EST ------- (In reply to comment #15) > > *rpmlint - PASS > > Umm??? Don't pass (see below) > > This is very strange indeed b/c the rpmlint passes > for me with flying colors. > > [a@buildbox ~]$ rpmlint /sw/BUILDING/RPMS/i386/astyle-1.20.2-2.fc7.i386.rpm > [a@buildbox ~]$ Well, when you rebuild srpm (by rpmbuild or mock), you should also have debuginfo rpm. For this package, there should be astyle-debuginfo rpm. Also, we have to check rpmlint error for src.rpm and the _installed_ rpm. > > *changelog - CHANGE > > -- should remove the last changelog comment > about a different version > > Why? > > Why? Because it's stated in the guidelines that changelog comments should > match the version of the pkg a person is packaging. This is for the *newest* (i.e. top) entry of the %changelog. > If she wants to pkg a > different version, she should have the comments for that version in its' spec > file, and not in this one. Well, please try "rpm -q --changelog coreutils", for example. BTW as this is NEEDSPONSOR blocker, will someone going to sponsor the reviewer, Ralf, Kevin (and me)? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review