[Bug 1288541] Review Request: perl-Code-TidyAll - Engine for tidyall, your all-in-one code tidier and validator

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1288541



--- Comment #2 from Petr Šabata <psabata@xxxxxxxxxx> ---
* You list the Test::Class::Most build time dependency twice.

* Some of the listed build time dependencies aren't actually necessary, namely:
  - autodie
  - IPC::System::Simple
  - List::Compare
  - Log::Any
  - Test::Builder

* One build time dependency missing: lib

* The package description is fairly poorly written and doesn't say much.

* The summary implies this package is just the engine, even though it also
  installs the utility it refers to.
  You could keep that and split the utility into a subpackage, if you think
  it makes sense.  Or change the summary.  Your call.

* Many of the plugins require external utilities you neither require nor
  recommend/suggest.  The package won't work as advertised without them.
  See the Code::TidyAll::Plugin namespace.

* Possibly similar situation with the VCSs -- will this work without git or
  subversion?  Maybe -- I don't know how these hooks are meant to be used.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]