Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mrxvt - Multi-tabbed terminal emulator. https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=223422 ------- Additional Comments From gnome@xxxxxxxxxxxxx 2007-06-17 23:43 EST ------- Mamoru, I've done a review of bug #207896. Please review my work when you have a chance. I have a few questions about the way their Makefile is structured, how they left out the %configure section and whether or not they need to ask the maintainer to separate the libs out from the pkg. The configure section makes sense and the way they use build does too, but I'm not sure if there is much precedent for such actions. I made a lot of comments, so please let me know what you think. I'm also incorporating the changes you made and posting a new build at the usual place (it should be up in a few): http://littlehat.homelinux.org:8000/FEDORA/mrxvt/current/0.5.2/ I will also be submitting another package for review in the near future. I will let you know when I'm done. Thank you for all your help. -Adam -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review