https://bugzilla.redhat.com/show_bug.cgi?id=1267328 --- Comment #3 from Mamoru TASAKA <mtasaka@xxxxxxxxxxxxxxxxx> --- Basically okay. Some requests and recommendations: * Unneeded document files - %{gem_instdir}/test As written on "Do not ship tests" in https://fedoraproject.org/wiki/Packaging:Ruby?rd=Packaging/Ruby#Running_test_suites , we request test/ directory *not* shipped in the rebuilt binary rpm. - Gemfile This is needed only for test suite and not needed on runtime. - Rakefile This is alike "Makefile" on autotools system and not needed on runtime. - %{gem_instdir}/connection_pool.gemspec This is usually needed only when creating gem itself and not needed on runtime (Note: %{gem_spec} is needed) * Other documentation recommendations * Mark %doc - Mark Changes.md as %doc * README.md - I would recommend that this file should be moved to main package because this says "README". -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review