https://bugzilla.redhat.com/show_bug.cgi?id=1288731 Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@xxxxxxxxxxxxxxxxx |zbyszek@xxxxxxxxx Flags| |fedora-review? --- Comment #4 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- Since it seems like it might help with QA, I'll do the review. Fedora <= 21 is no more, so some conditions in the spec file can be simplified. Group tag is not necessary. s/Openvswitch/Open vSwitch/ in the summary, maybe. Is R:git needed, or would just R:git-core be enough? find %{buildroot} -type f -name .packlist -print0 | xargs -0 --no-run-if-empty rm -f → find %{buildroot} -type f -name .packlist -delete ? or even %global NO_PACKLIST? find %{buildroot} -depth -type d -and -not -name distri -print0 | xargs -0 --no-run-if-empty rmdir 2>/dev/null || true → find %{buildroot} -depth -type d -and -not -name distri -exec rmdir {} \; ? Dunno, I'd just put %_libexedri/os-autoinst in %files, because it's going to be a pain on every upgrade... https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Systemd are required for os-autoinst-openvswitch.service. fedora-review says: - Package contains BR: python2-devel or python3-devel - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file COPYING is marked as %doc instead of %license See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text [ ]: %config files are marked noreplace or the reason is justified. Note: No (noreplace) in %config /etc/dbus-1/system.d/org.opensuse.os_autoinst.switch.conf This is an upstream issue, maybe you can report it: [!]: Package should not use obsolete m4 macros Note: Some obsoleted macros found, see the attachment. See: https://fedorahosted.org/FedoraReview/wiki/AutoTools AutoTools: Obsoleted m4s found ------------------------------ AC_PROG_LIBTOOL found in: os-autoinst- 5ce7dc56e6a7478e225f9018e02ed890a327cfbf/configure.ac:24 os-autoinst.x86_64: E: version-control-internal-file /usr/libexec/os-autoinst/distri/.gitignore -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review