https://bugzilla.redhat.com/show_bug.cgi?id=1234210 --- Comment #32 from Ranjan Maitra <itsme_410@xxxxxxxxx> --- (In reply to Parag AN(पराग) from comment #31) > I just checked above spec file link. Here are some suggestions > > 1) If you are packaging python2 library or tools then your spec file should > use %{__python2} macros only. See > https://fedoraproject.org/wiki/Packaging:Python#Macros > > 2) Its always a good practice to increase the release number when you > provide updated package here. That will help what has changed since your > last package update to new package update. > > 3) The recent changelog entry looks longer than 80 characters. > > 4) Good to add comment just above the mv command line in %install that > # Fedora already have stapler package that is > # why this package is named as pdf-stapler Done. New files uploaded: SRPM: http://maitra.public.iastate.edu/Fedora/pdf-stapler-0.3.3-3.fc23.src.rpm SPEC: http://maitra.public.iastate.edu/Fedora/pdf-stapler.spec ( -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review