Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mksh - MirBSD enhanced version of the Korn Shell https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=242537 dev@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From dev@xxxxxxxxxx 2007-06-17 00:14 EST ------- Package name: OK (mksh) License: OK (BSD) Spec Legible: OK (en_US) md5sum matches: OK (83b4ca84faa1a1ea4cf6db6eb41a0384) rpmlint clean: OK (Acceptable warnings) Builds correctly: OK (i386) Spec has %clean: OK Macro use consistant: OK Contains code/content: OK -doc subpackage: NA -devel subpackage: NA -static subpackage: NA pkgconfig depend: NA Contains %doc: OK (copyright dot.mkshrc) Library suffix: NA No .la files: NA Use desktop-file-install: NA No duplicate ownerships: OK rm -rf %{buildroot}: OK RPM uses valid UTF-8: OK %defattr is set: OK No duplicate %files: OK Not relocatable: OK Calls ldconfig: NA Supports Locales: NA BR's are correct: OK MUST FIX: mksh.spec: if [ ! -f %{_sysconfdir}/shells ]; then echo "%{_bindir}/%{name}" >> %%{_sysconfdir}/shells else grep -q "^%{_bindir}/%{name}$" %{_sysconfdir}/shells || \ echo "%{_bindir}/%{name}" >> %{_sysconfdir}/shells fi Please remove the double % APPROVED (n.b. it builds on EL-5 (and should on EL-4) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review