[Bug 1187030] Review Request: giza - scientific plotting library for C/Fortran

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1187030



--- Comment #11 from Michael Schwendt <bugs.michael@xxxxxxx> ---
Hello guys,

this one is a head-scratcher. :-/

1) Björn had assigned the ticket to himself already and apparently was willing
to sponsor Joachim.

2) Christopher deleted the "fedora-review?" flag. Rude indeed. Btw, if deleting
that flag, don't forget to restore the "Assigned To" field and readd the
FE-NEEDSPONSOR to the "Blocks" field, or else the ticket does not appear on the
needsponsor queue tracker page: http://fedoraproject.org/PackageReviewStatus/

3) A second review ticket bug 1275216 for a completely different package is
very bad style.

Both packages differ a lot. Not just the src.rpm, also the build results. Do
you think it's possible to agree on the packaging of "giza"?

[...]

> Spec URL: http://1drv.ms/1ReBiIo
> SRPM URL: http://1drv.ms/1jToMQ3

Microsoft OneDrive is not compatible with fedora-review, as no direct download
from such URLs is possible.

Consider following comment 5 to acquire fedorapeople.org webspace.

Then point the fedora-review tool at this ticket: fedora-review -b 1187030


> Name:           giza
> Group:          Development/Libraries

The base Group tag for runtime library packages has been "System
Environment/Libraries" for many years dating back to Red Hat Linux. Nowadays,
the Group tag is optional:
  https://fedoraproject.org/wiki/Packaging:Guidelines#Group_tag

On the contrary, "Development/Libraries" is the Group for library -devel
packages.


> Patch0:         makefile.patch
> Patch1:         marker.patch

https://fedoraproject.org/wiki/Packaging:Guidelines#Patch_Guidelines


> %build
> %configure --disable-static
> make

https://fedoraproject.org/wiki/Packaging:Guidelines#Parallel_make
https://fedoraproject.org/wiki/Packaging:Guidelines#Compiler_flags

Build output is non-verbose. One cannot verify the compiler/linker options that
are used during building. 

Try passing "V=1" to Make. If that doesn't work, it may be necessary need to
search for ways to disable silent build rules.


> %install
> rm -rf $RPM_BUILD_ROOT

https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag


> %doc AUTHORS ChangeLog COPYING INSTALL NEWS README

https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text

Plus, the INSTALL file does not contain anything worthwhile to RPM package
users.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]