https://bugzilla.redhat.com/show_bug.cgi?id=1289634 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #11 from Petr Pisar <ppisar@xxxxxxxxxx> --- Spec file changes: --- libchardet.spec.old 2015-12-10 20:09:31.000000000 +0100 +++ libchardet.spec 2015-12-11 14:57:03.000000000 +0100 @@ -1,15 +1,24 @@ Name: libchardet Version: 1.0.4 -Release: 2%{?dist} +Release: 3%{?dist} Summary: Mozilla's universal character set detector Group: System Environment/Libraries License: MPLv1.1 or LGPLv2+ or GPLv2+ URL: http://ftp.oops.org/pub/oops/libchardet/ # wget http://ftp.oops.org/pub/oops/libchardet/libchardet-1.0.4.tar.bz2 Source0: %{name}-%{version}.tar.bz2 -Patch0: %{name}-%{version}-man.patch -Patch1: %{name}-%{version}-pc.in.patch +Patch0: %{name}-1.0.4-man.patch +Patch1: %{name}-1.0.4-pc.in.patch + BuildRequires: libstdc++-devel +BuildRequires: glibc-common +BuildRequires: coreutils +BuildRequires: make +BuildRequires: findutils +BuildRequires: gcc +BuildRequires: gcc-c++ +BuildRequires: sed +BuildRequires: perl %description libchardet provides an interface to Mozilla's universal charset detector, @@ -45,7 +54,7 @@ %install make DESTDIR=%{buildroot} install -%find_lang %{name} --with-man --all-name +%find_lang %{name}-devel --with-man --all-name # remove all '*.la' files find %{buildroot} -name '*.la' -exec rm -f {} ';' @@ -57,12 +66,12 @@ %postun -p /sbin/ldconfig -%files -f %{name}.lang +%files %doc Changelog README %license LICENSE %{_libdir}/%{name}.so.* -%files devel +%files devel -f %{name}-devel.lang %{_bindir}/chardet-config %{_libdir}/*.so %{_libdir}/pkgconfig/chardet.pc @@ -70,6 +79,18 @@ %{_mandir}/man3/* %changelog +* Fri Dec 11 2015 Martin Gansser <martinkg@xxxxxxxxxxxxxxxxx> - 1.0.4-3 +- renamed %%version macro for patches +- added BR glibc-common +- added BR coreutils +- added BR make +- added BR findutils +- added BR gcc +- added BR gcc-c++ +- added BR sed +- added BR perl +- moved Korean manual pages to devel sub-package + * Thu Dec 10 2015 Martin Gansser <martinkg@xxxxxxxxxxxxxxxxx> - 1.0.4-2 - fixed url address - fixed license tag > TODO: I recommend not to use the %version macro here. -Patch0: %{name}-%{version}-man.patch -Patch1: %{name}-%{version}-pc.in.patch +Patch0: %{name}-1.0.4-man.patch +Patch1: %{name}-1.0.4-pc.in.patch Ok. > > FIX: Build-require `glibc-common' (libchardet.spec:33). > > FIX: Build-require `coreutils' (libchardet.spec:34). > > FIX: Build-require `make' (libchardet.spec:40). > > FIX: Build-require `findutils' (libchardet.spec:48). > > FIX: Build-require `gcc' for including various standard library headers and having > > toolchain for compilation. > > FIX: Build-require `gcc-c++' for having compiler for the C++ code. > > FIX: Build-require `sed' (configure.ac:24). > > FIX: Build-require `perl' (configure.ac:46). > FIX: Really add the build-requires. It's necessary to specify all directly used > dependencies. +BuildRequires: glibc-common +BuildRequires: coreutils +BuildRequires: make +BuildRequires: findutils +BuildRequires: gcc +BuildRequires: gcc-c++ +BuildRequires: sed +BuildRequires: perl Ok. $ rpmlint libchardet.spec ../SRPMS/libchardet-1.0.4-3.fc24.src.rpm ../RPMS/x86_64/libchardet-* libchardet.spec: W: invalid-url Source0: libchardet-1.0.4.tar.bz2 libchardet.src: W: invalid-url URL: http://ftp.oops.org/pub/oops/libchardet/ <urlopen error [Errno 111] Connection refused> libchardet.src: W: invalid-url Source0: libchardet-1.0.4.tar.bz2 libchardet.x86_64: W: invalid-url URL: http://ftp.oops.org/pub/oops/libchardet/ <urlopen error [Errno 111] Connection refused> libchardet-debuginfo.x86_64: W: invalid-url URL: http://ftp.oops.org/pub/oops/libchardet/ <urlopen error [Errno 111] Connection refused> libchardet-devel.x86_64: W: invalid-url URL: http://ftp.oops.org/pub/oops/libchardet/ <urlopen error [Errno 111] Connection refused> libchardet-devel.x86_64: W: only-non-binary-in-usr-lib libchardet-devel.x86_64: W: no-manual-page-for-binary chardet-config 4 packages and 1 specfiles checked; 0 errors, 8 warnings. rpmlint is Ok. > FIX: Move the Korean manual pages to devel sub-package. $ rpm -q -l -p ../RPMS/x86_64/libchardet-1.0.4-3.fc24.x86_64.rpm /usr/lib64/libchardet.so.1 /usr/lib64/libchardet.so.1.0.0 /usr/share/doc/libchardet /usr/share/doc/libchardet/Changelog /usr/share/doc/libchardet/README /usr/share/licenses/libchardet /usr/share/licenses/libchardet/LICENSE $ rpm -q -l -p ../RPMS/x86_64/libchardet-devel-1.0.4-3.fc24.x86_64.rpm /usr/bin/chardet-config /usr/include/chardet/chardet-config.h /usr/include/chardet/chardet.h /usr/include/chardet/nsUniversalDetector.h /usr/include/chardet/nscore.h /usr/include/chardet/version.h /usr/lib64/libchardet.so /usr/lib64/pkgconfig/chardet.pc /usr/share/man/ko/man3/detect.3.gz /usr/share/man/ko/man3/detect_destroy.3.gz /usr/share/man/ko/man3/detect_handledata.3.gz /usr/share/man/ko/man3/detect_init.3.gz /usr/share/man/ko/man3/detect_obj_free.3.gz /usr/share/man/ko/man3/detect_obj_init.3.gz /usr/share/man/ko/man3/detect_reset.3.gz /usr/share/man/man3/detect.3.gz /usr/share/man/man3/detect_destroy.3.gz /usr/share/man/man3/detect_handledata.3.gz /usr/share/man/man3/detect_init.3.gz /usr/share/man/man3/detect_obj_free.3.gz /usr/share/man/man3/detect_obj_init.3.gz /usr/share/man/man3/detect_reset.3.gz File layout is Ok. Package builds in F24 (http://koji.fedoraproject.org/koji/taskinfo?taskID=12153893). Ok. Package is good. Resolution: Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review