https://bugzilla.redhat.com/show_bug.cgi?id=1290537 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #5 from Petr Pisar <ppisar@xxxxxxxxxx> --- Spec file changes: --- perl-HTTP-Tinyish.spec.old 2015-12-10 19:15:11.000000000 +0100 +++ perl-HTTP-Tinyish.spec 2015-12-11 12:42:07.000000000 +0100 @@ -1,6 +1,6 @@ Name: perl-HTTP-Tinyish Version: 0.06 -Release: 1%{?dist} +Release: 2%{?dist} Summary: HTTP::Tiny compatible HTTP client wrappers License: GPL+ or Artistic URL: http://search.cpan.org/dist/HTTP-Tinyish/ @@ -18,7 +18,7 @@ # BuildRequires: perl(File::Which) # BuildRequires: perl(HTTP::Tiny) >= 0.054 # BuildRequires: perl(IPC::Run3) -# BuildRequires: perl(LWP) >= 5.002 +# BuildRequires: perl(LWP) >= 5.802 # BuildRequires: perl(LWP::Protocol::https) # BuildRequires: perl(LWP::UserAgent) # BuildRequires: perl(parent) @@ -26,6 +26,7 @@ BuildRequires: perl(JSON::PP) BuildRequires: perl(Test::More) >= 0.96 Requires: perl(:MODULE_COMPAT_%(eval "$(perl -V:version)"; echo $version)) +Requires: perl(:HTTP-Tinyish:backend) Recommends: perl(HTTP::Tinyish::LWP) %global __requires_exclude %{?__requires_exclude:%__requires_exclude|}^perl\\(HTTP::Tiny\\)$ @@ -34,30 +35,38 @@ HTTP::Tinyish is a wrapper module for HTTP client modules LWP, HTTP::Tiny and HTTP client software curl and wget. -%package Curl -Summary: HTTP::Tinyish curl backend -Requires: curl +%package Curl +Summary: HTTP::Tinyish curl backend +Requires: perl(:MODULE_COMPAT_%(eval "$(perl -V:version)"; echo $version)) +Requires: curl +Provides: perl(:HTTP-Tinyish:backend) %description Curl %{summary}. -%package HTTPTiny -Summary: HTTP::Tinyish HTTP::Tiny backend -Requires: perl(HTTP::Tiny) >= 0.054 +%package HTTPTiny +Summary: HTTP::Tinyish HTTP::Tiny backend +Requires: perl(:MODULE_COMPAT_%(eval "$(perl -V:version)"; echo $version)) +Requires: perl(HTTP::Tiny) >= 0.054 +Provides: perl(:HTTP-Tinyish:backend) %description HTTPTiny %{summary}. -%package LWP -Summary: HTTP::Tinyish LWP backend -Recommends: perl(LWP::Protocol::https) +%package LWP +Summary: HTTP::Tinyish LWP backend +Requires: perl(:MODULE_COMPAT_%(eval "$(perl -V:version)"; echo $version)) +Provides: perl(:HTTP-Tinyish:backend) +Recommends: perl(LWP::Protocol::https) %description LWP %{summary}. -%package Wget -Summary: HTTP::Tinyish wget backend -Requires: wget +%package Wget +Summary: HTTP::Tinyish wget backend +Requires: perl(:MODULE_COMPAT_%(eval "$(perl -V:version)"; echo $version)) +Requires: wget +Provides: perl(:HTTP-Tinyish:backend) %description Wget %{summary}. @@ -81,6 +90,7 @@ %files %license LICENSE %doc Changes README +%dir %{perl_vendorlib}/HTTP %{perl_vendorlib}/HTTP/Tinyish.pm %{perl_vendorlib}/HTTP/Tinyish/Base.pm %{_mandir}/man3/HTTP::Tinyish.* @@ -102,5 +112,8 @@ %{perl_vendorlib}/HTTP/Tinyish/Wget.pm %changelog +* Fri Dec 11 2015 Petr Šabata <contyk@xxxxxxxxxx> - 0.06-2 +- Address the reviewer's concerns + * Thu Dec 10 2015 Petr Šabata <contyk@xxxxxxxxxx> 0.06-1 - Initial packaging > TODO: Correct the LWP minimal version in the comment to 5.802 > (lib/HTTP/Tinyish/LWP.pm:5). -# BuildRequires: perl(LWP) >= 5.002 +# BuildRequires: perl(LWP) >= 5.802 Ok. $ rpmlint perl-HTTP-Tinyish.spec ../SRPMS/perl-HTTP-Tinyish-0.06-2.fc24.src.rpm ../RPMS/noarch/perl-HTTP-Tinyish-* perl-HTTP-Tinyish.spec:42: W: unversioned-explicit-provides perl(:HTTP-Tinyish:backend) perl-HTTP-Tinyish.spec:51: W: unversioned-explicit-provides perl(:HTTP-Tinyish:backend) perl-HTTP-Tinyish.spec:59: W: unversioned-explicit-provides perl(:HTTP-Tinyish:backend) perl-HTTP-Tinyish.spec:69: W: unversioned-explicit-provides perl(:HTTP-Tinyish:backend) perl-HTTP-Tinyish.src:42: W: unversioned-explicit-provides perl(:HTTP-Tinyish:backend) perl-HTTP-Tinyish.src:51: W: unversioned-explicit-provides perl(:HTTP-Tinyish:backend) perl-HTTP-Tinyish.src:59: W: unversioned-explicit-provides perl(:HTTP-Tinyish:backend) perl-HTTP-Tinyish.src:69: W: unversioned-explicit-provides perl(:HTTP-Tinyish:backend) perl-HTTP-Tinyish-Curl.noarch: W: no-documentation perl-HTTP-Tinyish-HTTPTiny.noarch: W: no-documentation perl-HTTP-Tinyish-LWP.noarch: W: no-documentation perl-HTTP-Tinyish-Wget.noarch: W: no-documentation 6 packages and 1 specfiles checked; 0 errors, 12 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-HTTP-Tinyish-0.06-2.fc24.noarch.rpm drwxr-xr-x 2 root root 0 Dec 11 13:19 /usr/share/doc/perl-HTTP-Tinyish -rw-r--r-- 1 root root 681 Sep 26 19:22 /usr/share/doc/perl-HTTP-Tinyish/Changes -rw-r--r-- 1 root root 3403 Sep 26 19:22 /usr/share/doc/perl-HTTP-Tinyish/README drwxr-xr-x 2 root root 0 Dec 11 13:19 /usr/share/licenses/perl-HTTP-Tinyish -rw-r--r-- 1 root root 18370 Sep 26 19:22 /usr/share/licenses/perl-HTTP-Tinyish/LICENSE -rw-r--r-- 1 root root 2641 Dec 11 13:18 /usr/share/man/man3/HTTP::Tinyish.3pm.gz drwxr-xr-x 2 root root 0 Dec 11 13:19 /usr/share/perl5/vendor_perl/HTTP -rw-r--r-- 1 root root 4872 Sep 26 19:22 /usr/share/perl5/vendor_perl/HTTP/Tinyish.pm -rw-r--r-- 1 root root 2181 Sep 26 19:22 /usr/share/perl5/vendor_perl/HTTP/Tinyish/Base.pm > FIX: The perl-HTTP-Tinyish package should own > /usr/share/perl5/vendor_perl/HTTP directory. Ok. FIX: The perl-HTTP-Tinyish package should also own /usr/share/perl5/vendor_perl/HTTP/Tinyish directory. > FIX: All the backend packages must require perl(:MODULE_COMPAT_*) symbol. $ for P in ../RPMS/noarch/perl-HTTP-Tinyish-*;do echo "${P}:"; rpm -q --requires -p "$P" | sort -f | uniq -c; done ../RPMS/noarch/perl-HTTP-Tinyish-0.06-2.fc24.noarch.rpm: 1 perl(:HTTP-Tinyish:backend) 1 perl(:MODULE_COMPAT_5.22.0) 1 perl(Carp) 1 perl(strict) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 ../RPMS/noarch/perl-HTTP-Tinyish-Curl-0.06-2.fc24.noarch.rpm: 1 curl 1 perl(:MODULE_COMPAT_5.22.0) 1 perl(File::Temp) 1 perl(File::Which) 1 perl(HTTP::Tinyish::Base) 1 perl(IPC::Run3) 1 perl(parent) 1 perl(strict) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 ../RPMS/noarch/perl-HTTP-Tinyish-HTTPTiny-0.06-2.fc24.noarch.rpm: 1 perl(:MODULE_COMPAT_5.22.0) 1 perl(HTTP::Tiny) >= 0.054 1 perl(HTTP::Tinyish::Base) 1 perl(parent) 1 perl(strict) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 ../RPMS/noarch/perl-HTTP-Tinyish-LWP-0.06-2.fc24.noarch.rpm: 1 perl(:MODULE_COMPAT_5.22.0) 1 perl(HTTP::Tinyish::Base) 1 perl(LWP) >= 5.802 1 perl(LWP::UserAgent) 1 perl(parent) 1 perl(strict) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 ../RPMS/noarch/perl-HTTP-Tinyish-Wget-0.06-2.fc24.noarch.rpm: 1 perl(:MODULE_COMPAT_5.22.0) 1 perl(File::Which) 1 perl(HTTP::Tinyish::Base) 1 perl(IPC::Run3) 1 perl(parent) 1 perl(strict) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 1 wget Binary requires are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-HTTP-Tinyish-* Binary dependencies resolvable. Ok. > TODO: It's possible to install perl-HTTP-Tinyish without any backend now. > I recommend to provide an RPM symbol by all the backends and require the > symbol by perl-HTTP-Tinyish. I'd rather see `perl-HTTP-Tinyish-backend' than `perl(:HTTP-Tinyish:backend)', but that's matter of taste. Ok. Package builds in F24 (http://koji.fedoraproject.org/koji/taskinfo?taskID=12152059). Ok. Please correct the `FIX' issue before building the package. Resolution: Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review