[Bug 1277161] Review Request: mod_mono - ASP.NET module for Apache

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1277161



--- Comment #6 from Claudio Rodrigo Pereyra DIaz <claudiorodrigo@xxxxxxxxxxxxxxxxxx> ---
Thanks James

Spec URL: https://elsupergomez.fedorapeople.org/SPECS/mod_mono.spec
SRPM URL:
https://elsupergomez.fedorapeople.org/SRPMS/mod_mono-3.12-3.fc21.src.rpm

(In reply to James Hogarth from comment #5)
> Just about there!
> 
> 1) As per the tmpfiles.d guidelines you should still create and own the
> directory in %install and %files
> 
> https://fedoraproject.org/wiki/Packaging:Tmpfiles.d
> 
> There's a sample spec on that wiki page you can copy and adjust to your
> needs.

Add creation on %install and %files

> 2) Think there was a copy/paste error in your tmpfiles configuration as your
> package is currently trying to configure /run/mysqld for use by apache ;)

My mistake. Fixed

> 
> 3) There's no need to call ldconfig as system libraries aren't being changed
> - that has no impact on the *.so loaded by httpd

Removed

> With that we should be pretty good for an APPROVED on a formal review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]