https://bugzilla.redhat.com/show_bug.cgi?id=1290537 --- Comment #2 from Petr Pisar <ppisar@xxxxxxxxxx> --- URL and Source0 addresses are usable. Ok. Source archive is original (SHA-256: 0a5a0cf275e0e030779460c15d369f90aafc8a13094a61b93156d9c1602d3ca3). Ok. Summary is Ok. Description is Ok. License verified from README, LICENSE, lib/HTTP/Tinyish.pm. Ok. No XS code, noarch BuildArch is Ok. TODO: Correct the LWP minimal version in the comment to 5.802 (lib/HTTP/Tinyish/LWP.pm:5). Test::Pod is not used. Ok. All test pass. Ok. $ rpmlint perl-HTTP-Tinyish.spec ../SRPMS/perl-HTTP-Tinyish-0.06-1.fc24.src.rpm ../RPMS/noarch/perl-HTTP-Tinyish-* perl-HTTP-Tinyish-Curl.noarch: W: no-documentation perl-HTTP-Tinyish-HTTPTiny.noarch: W: no-documentation perl-HTTP-Tinyish-LWP.noarch: W: no-documentation perl-HTTP-Tinyish-Wget.noarch: W: no-documentation 6 packages and 1 specfiles checked; 0 errors, 4 warnings. rpmlint is Ok. $ for P in ../RPMS/noarch/perl-HTTP-Tinyish-*;do echo "${P}:"; rpm -q -lv -p "$P"; done ../RPMS/noarch/perl-HTTP-Tinyish-0.06-1.fc24.noarch.rpm: drwxr-xr-x 2 root root 0 Dec 11 10:02 /usr/share/doc/perl-HTTP-Tinyish -rw-r--r-- 1 root root 681 Sep 26 19:22 /usr/share/doc/perl-HTTP-Tinyish/Changes -rw-r--r-- 1 root root 3403 Sep 26 19:22 /usr/share/doc/perl-HTTP-Tinyish/README drwxr-xr-x 2 root root 0 Dec 11 10:02 /usr/share/licenses/perl-HTTP-Tinyish -rw-r--r-- 1 root root 18370 Sep 26 19:22 /usr/share/licenses/perl-HTTP-Tinyish/LICENSE -rw-r--r-- 1 root root 2641 Dec 11 10:02 /usr/share/man/man3/HTTP::Tinyish.3pm.gz -rw-r--r-- 1 root root 4872 Sep 26 19:22 /usr/share/perl5/vendor_perl/HTTP/Tinyish.pm -rw-r--r-- 1 root root 2181 Sep 26 19:22 /usr/share/perl5/vendor_perl/HTTP/Tinyish/Base.pm ../RPMS/noarch/perl-HTTP-Tinyish-Curl-0.06-1.fc24.noarch.rpm: drwxr-xr-x 2 root root 0 Dec 11 10:02 /usr/share/licenses/perl-HTTP-Tinyish-Curl -rw-r--r-- 1 root root 18370 Sep 26 19:22 /usr/share/licenses/perl-HTTP-Tinyish-Curl/LICENSE -rw-r--r-- 1 root root 3330 Sep 26 19:22 /usr/share/perl5/vendor_perl/HTTP/Tinyish/Curl.pm ../RPMS/noarch/perl-HTTP-Tinyish-HTTPTiny-0.06-1.fc24.noarch.rpm: drwxr-xr-x 2 root root 0 Dec 11 10:02 /usr/share/licenses/perl-HTTP-Tinyish-HTTPTiny -rw-r--r-- 1 root root 18370 Sep 26 19:22 /usr/share/licenses/perl-HTTP-Tinyish-HTTPTiny/LICENSE -rw-r--r-- 1 root root 595 Sep 26 19:22 /usr/share/perl5/vendor_perl/HTTP/Tinyish/HTTPTiny.pm ../RPMS/noarch/perl-HTTP-Tinyish-LWP-0.06-1.fc24.noarch.rpm: drwxr-xr-x 2 root root 0 Dec 11 10:02 /usr/share/licenses/perl-HTTP-Tinyish-LWP -rw-r--r-- 1 root root 18370 Sep 26 19:22 /usr/share/licenses/perl-HTTP-Tinyish-LWP/LICENSE -rw-r--r-- 1 root root 2420 Sep 26 19:22 /usr/share/perl5/vendor_perl/HTTP/Tinyish/LWP.pm ../RPMS/noarch/perl-HTTP-Tinyish-Wget-0.06-1.fc24.noarch.rpm: drwxr-xr-x 2 root root 0 Dec 11 10:02 /usr/share/licenses/perl-HTTP-Tinyish-Wget -rw-r--r-- 1 root root 18370 Sep 26 19:22 /usr/share/licenses/perl-HTTP-Tinyish-Wget/LICENSE -rw-r--r-- 1 root root 4677 Sep 26 19:22 /usr/share/perl5/vendor_perl/HTTP/Tinyish/Wget.pm FIX: The perl-HTTP-Tinyish package should own /usr/share/perl5/vendor_perl/HTTP directory. $ for P in ../RPMS/noarch/perl-HTTP-Tinyish-*;do echo "${P}:"; rpm -q --requires -p "$P" | sort -f | uniq -c; done ../RPMS/noarch/perl-HTTP-Tinyish-0.06-1.fc24.noarch.rpm: 1 perl(:MODULE_COMPAT_5.22.0) 1 perl(Carp) 1 perl(strict) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 ../RPMS/noarch/perl-HTTP-Tinyish-Curl-0.06-1.fc24.noarch.rpm: 1 curl 1 perl(File::Temp) 1 perl(File::Which) 1 perl(HTTP::Tinyish::Base) 1 perl(IPC::Run3) 1 perl(parent) 1 perl(strict) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 ../RPMS/noarch/perl-HTTP-Tinyish-HTTPTiny-0.06-1.fc24.noarch.rpm: 1 perl(HTTP::Tiny) >= 0.054 1 perl(HTTP::Tinyish::Base) 1 perl(parent) 1 perl(strict) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 ../RPMS/noarch/perl-HTTP-Tinyish-LWP-0.06-1.fc24.noarch.rpm: 1 perl(HTTP::Tinyish::Base) 1 perl(LWP) >= 5.802 1 perl(LWP::UserAgent) 1 perl(parent) 1 perl(strict) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 ../RPMS/noarch/perl-HTTP-Tinyish-Wget-0.06-1.fc24.noarch.rpm: 1 perl(File::Which) 1 perl(HTTP::Tinyish::Base) 1 perl(IPC::Run3) 1 perl(parent) 1 perl(strict) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 1 wget FIX: All the backend packages must require perl(:MODULE_COMPAT_*) symbol. TODO: It's possible to install perl-HTTP-Tinyish without any backend now. I recommend to provide an RPM symbol by all the backends and require the symbol by perl-HTTP-Tinyish. $ for P in ../RPMS/noarch/perl-HTTP-Tinyish-*;do echo "${P}:"; rpm -q --provides -p "$P" | sort -f | uniq -c; done ../RPMS/noarch/perl-HTTP-Tinyish-0.06-1.fc24.noarch.rpm: 1 perl(HTTP::Tinyish) = 0.06 1 perl(HTTP::Tinyish::Base) 1 perl-HTTP-Tinyish = 0.06-1.fc24 ../RPMS/noarch/perl-HTTP-Tinyish-Curl-0.06-1.fc24.noarch.rpm: 1 perl(HTTP::Tinyish::Curl) 1 perl-HTTP-Tinyish-Curl = 0.06-1.fc24 ../RPMS/noarch/perl-HTTP-Tinyish-HTTPTiny-0.06-1.fc24.noarch.rpm: 1 perl(HTTP::Tinyish::HTTPTiny) 1 perl-HTTP-Tinyish-HTTPTiny = 0.06-1.fc24 ../RPMS/noarch/perl-HTTP-Tinyish-LWP-0.06-1.fc24.noarch.rpm: 1 perl(HTTP::Tinyish::LWP) 1 perl-HTTP-Tinyish-LWP = 0.06-1.fc24 ../RPMS/noarch/perl-HTTP-Tinyish-Wget-0.06-1.fc24.noarch.rpm: 1 perl(HTTP::Tinyish::Wget) 1 perl-HTTP-Tinyish-Wget = 0.06-1.fc24 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-HTTP-Tinyish-*; Binary dependencies resolvable. Ok. Package builds in F24 (http://koji.fedoraproject.org/koji/taskinfo?taskID=12149066). Ok. Otherwise the package is in line with Fedora and Perl packaging guidelines. Please correct all `FIX' items, consider fixing `TODO' items and provide new spec file. Resolution: Package NOT approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review