[Bug 1289478] Review Request: hystrix - Library for Latency and Fault Tolerance in Distributed Systems

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1289478



--- Comment #4 from Martin Sivák <msivak@xxxxxxxxxx> ---
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- If (and only if) the source package includes the text of the license(s)
  in its own file, then that file, containing the text of the license(s)
  for the package is included in %license.
  Note: Cannot find LICENSE.txt in rpm(s)
  See:
  http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text

  Because the file is called LICENSE

===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Apache (v2.0)", "Unknown or generated". 25 files have unknown
     license. Detailed output of licensecheck in
     /home/msivak/tmp/1289478-hystrix/licensecheck.txt
     ASL 2.0 both upstream and in the package

[x]: License file installed when any subpackage combination is installed.
     Each subpackage installs a license

[x]: Package requires other packages for directories it uses.
     Note: No known owner of /usr/share/webapps, /usr/share/licenses,
     /usr/share/jetty/webapps, /usr/share/maven-metadata, /usr/share/jetty
     All provided by dependencies or prescribed by guidelines

[x]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/share/jetty/webapps,
     /usr/share/webapps, /usr/share/jetty, /usr/share/licenses, /usr/share
     /maven-metadata
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 71680 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Java:
[x]: Bundled jar/class files should be removed before build
[x]: Packages have proper BuildRequires/Requires on jpackage-utils
     Note: Maven packages do not need to (Build)Require jpackage-utils. It
     is pulled in by maven-local
[x]: Javadoc documentation files are generated and included in -javadoc
     subpackage
[x]: Javadoc subpackages should not have Requires: jpackage-utils
[x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink)

Maven:
[-]: If package contains pom.xml files install it (including metadata) even
     when building with ant
[x]: Old add_to_maven_depmap macro is not being used

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
     Upstream provides the license
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in hystrix-
     core , hystrix-metrics-event-stream , hystrix-javadoc , hystrix-
     dashboard
     The subpackage dependency is defines using the mvn() = version syntax
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
     justified.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
     Unitests are executed as part of the build step according to the
     java guidelines.
[-]: Packages should try to preserve timestamps of original installed
     files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

Java:
[x]: Package uses upstream build method (ant/maven/etc.)
[x]: Packages are noarch unless they use JNI

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
     - Dangling symlinks are related to a WAR file packaging
       and are explicitly mentioned in the java guidelines
     - Servlet is a correct spelling

[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: hystrix-core-1.4.21-4.fc24.noarch.rpm
          hystrix-metrics-event-stream-1.4.21-4.fc24.noarch.rpm
          hystrix-javadoc-1.4.21-4.fc24.noarch.rpm
          hystrix-dashboard-1.4.21-4.fc24.noarch.rpm
          hystrix-1.4.21-4.fc24.src.rpm
hystrix-metrics-event-stream.noarch: W: no-documentation
hystrix-dashboard.noarch: W: no-documentation
hystrix-dashboard.noarch: W: dangling-symlink
/usr/share/webapps/hystrix/hystrix-dashboard/WEB-INF/lib/commons-codec.jar
/usr/share/java/commons-codec.jar
hystrix-dashboard.noarch: W: dangling-symlink
/usr/share/webapps/hystrix/hystrix-dashboard/WEB-INF/lib/httpclient.jar
/usr/share/java/httpcomponents/httpclient.jar
hystrix-dashboard.noarch: W: dangling-symlink
/usr/share/webapps/hystrix/hystrix-dashboard/WEB-INF/lib/slf4j-log4j12.jar
/usr/share/java/slf4j/slf4j-log4j12.jar
hystrix-dashboard.noarch: W: dangling-symlink
/usr/share/webapps/hystrix/hystrix-dashboard/WEB-INF/lib/log4j-1.2.17.jar
/usr/share/java/log4j-1.2.17.jar
hystrix-dashboard.noarch: W: dangling-symlink
/usr/share/webapps/hystrix/hystrix-dashboard/WEB-INF/lib/commons-logging.jar
/usr/share/java/commons-logging.jar
hystrix-dashboard.noarch: W: dangling-symlink
/usr/share/webapps/hystrix/hystrix-dashboard/WEB-INF/lib/httpcore.jar
/usr/share/java/httpcomponents/httpcore.jar
hystrix-dashboard.noarch: W: dangling-symlink
/usr/share/webapps/hystrix/hystrix-dashboard/WEB-INF/lib/slf4j-api.jar
/usr/share/java/slf4j/slf4j-api.jar
5 packages and 0 specfiles checked; 0 errors, 9 warnings.




Rpmlint (installed packages)
----------------------------
sh: /usr/bin/python: No such file or directory
hystrix-dashboard.noarch: W: no-documentation
hystrix-dashboard.noarch: W: dangling-symlink
/usr/share/webapps/hystrix/hystrix-dashboard/WEB-INF/lib/commons-codec.jar
/usr/share/java/commons-codec.jar
hystrix-dashboard.noarch: W: dangling-symlink
/usr/share/webapps/hystrix/hystrix-dashboard/WEB-INF/lib/httpclient.jar
/usr/share/java/httpcomponents/httpclient.jar
hystrix-dashboard.noarch: W: dangling-symlink
/usr/share/webapps/hystrix/hystrix-dashboard/WEB-INF/lib/slf4j-log4j12.jar
/usr/share/java/slf4j/slf4j-log4j12.jar
hystrix-dashboard.noarch: W: dangling-symlink
/usr/share/webapps/hystrix/hystrix-dashboard/WEB-INF/lib/httpcore.jar
/usr/share/java/httpcomponents/httpcore.jar
hystrix-dashboard.noarch: W: dangling-symlink
/usr/share/webapps/hystrix/hystrix-dashboard/WEB-INF/lib/slf4j-api.jar
/usr/share/java/slf4j/slf4j-api.jar
hystrix-dashboard.noarch: W: dangling-symlink
/usr/share/webapps/hystrix/hystrix-dashboard/WEB-INF/lib/log4j-1.2.17.jar
/usr/share/java/log4j-1.2.17.jar
hystrix-dashboard.noarch: W: dangling-symlink
/usr/share/webapps/hystrix/hystrix-dashboard/WEB-INF/lib/commons-logging.jar
/usr/share/java/commons-logging.jar
hystrix-metrics-event-stream.noarch: W: spelling-error Summary(en_US) servlet
-> settler
hystrix-metrics-event-stream.noarch: W: spelling-error %description -l en_US
servlet -> settler
hystrix-metrics-event-stream.noarch: W: no-documentation
4 packages and 0 specfiles checked; 0 errors, 11 warnings.



Requires
--------
hystrix-core (rpmlib, GLIBC filtered):
    java-headless
    jpackage-utils
    mvn(com.netflix.archaius:archaius-core)
    mvn(io.reactivex:rxjava)
    mvn(org.slf4j:slf4j-api)

hystrix-javadoc (rpmlib, GLIBC filtered):
    jpackage-utils

hystrix-dashboard (rpmlib, GLIBC filtered):
    jetty
    mvn(log4j:log4j)
    mvn(org.apache.httpcomponents:httpclient)
    mvn(org.slf4j:slf4j-log4j12)

hystrix-metrics-event-stream (rpmlib, GLIBC filtered):
    java-headless
    jpackage-utils
    mvn(com.fasterxml.jackson.core:jackson-core)
    mvn(com.netflix.hystrix:hystrix-core)



Provides
--------
hystrix-core:
    hystrix-core
    mvn(com.netflix.hystrix:hystrix-core)
    osgi(com.netflix.hystrix.core)

hystrix-javadoc:
    hystrix-javadoc

hystrix-dashboard:
    hystrix-dashboard

hystrix-metrics-event-stream:
    hystrix-metrics-event-stream
    mvn(com.netflix.hystrix:hystrix-metrics-event-stream)



Source checksums
----------------
https://github.com/Netflix/Hystrix/archive/v1.4.21.tar.gz#/hystrix-1.4.21.tar.gz
:
  CHECKSUM(SHA256) this package     :
3a590b0f3344b9e6d352b4711351869e0c21c01d7f97b83c6736bfe1487a013d
  CHECKSUM(SHA256) upstream package :
3a590b0f3344b9e6d352b4711351869e0c21c01d7f97b83c6736bfe1487a013d


Generated by fedora-review 0.5.3 (bcf15e3) last change: 2015-05-04
Command line :/usr/bin/fedora-review -b 1289478 -m fedora-rawhide-x86_64
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api, Java
Disabled plugins: C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R,
PHP, Ruby
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]