https://bugzilla.redhat.com/show_bug.cgi?id=1279104 Jeremy Cline <jeremy@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jeremy@xxxxxxxxxx --- Comment #2 from Jeremy Cline <jeremy@xxxxxxxxxx> --- Hi Samual, Like you, I'm looking to become a maintainer, so my review is informal. I do hope it is helpful, though! 1) In your Summary, I believe you need to replace "An module" with "A module". 2) According to the Pypi page, this project supports Python 3. According to the Python packaging guidelines, if a project supports Python 3 it must be packaged for Python 3[0] (you can package it for Python 2, as well). 3) There are several macros available for your use[1]. You should look into %py2_build, %py3_build, %py2_install, and %py3_install. 4) You do not need to run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. 5) You need to include a %license in %files. In this case, upstream doesn't appear to include the license in their repository (and you should probably suggest that they do that), but according to Pypi it's licensed using the MIT license. 6) You need to use %python_provides[2] Hopefully this is helpful. Good luck with your review! [0] https://fedoraproject.org/wiki/Packaging:Python#Python_Version_Support [1] https://fedoraproject.org/wiki/Packaging:Python#Macros [2] https://fedoraproject.org/wiki/Packaging:Python#The_.25python_provide_macro -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review