[Bug 1289478] Review Request: hystrix - Library for Latency and Fault Tolerance in Distributed Systems

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1289478



--- Comment #2 from Roman Mohr <roman@xxxxxxxxxxxx> ---
(In reply to Martin Sivák from comment #1)

Hi Martin,

thanks for doing the review.

> Please fix the ownership of:
> 
> /usr/share/webapps/hystrix
> 
> Summary should not end with a dot:
> 
> hystrix-core.noarch: W: summary-ended-with-dot C Core module of Hystrix.

Fixed

> Please fix the dashboard WAR symlinks. Those should not be determined at the
> build time, but dynamically recreated at the time of installation (probably
> %post):

According to [1] it should be done this way.
> 
> hystrix-dashboard.noarch: W: dangling-symlink
> /usr/share/webapps/hystrix/hystrix-dashboard/WEB-INF/lib/commons-codec.jar
> /usr/share/java/commons-codec.jar
> hystrix-dashboard.noarch: W: dangling-symlink
> /usr/share/webapps/hystrix/hystrix-dashboard/WEB-INF/lib/httpclient.jar
> /usr/share/java/httpcomponents/httpclient.jar
> hystrix-dashboard.noarch: W: dangling-symlink
> /usr/share/webapps/hystrix/hystrix-dashboard/WEB-INF/lib/slf4j-log4j12.jar
> /usr/share/java/slf4j/slf4j-log4j12.jar
> hystrix-dashboard.noarch: W: dangling-symlink
> /usr/share/webapps/hystrix/hystrix-dashboard/WEB-INF/lib/log4j-1.2.17.jar
> /usr/share/java/log4j-1.2.17.jar

This link indeed looks strange because of the version in the target jar file
name. Did some research: The logging bridge slf4j-log4j12 is tied to the
specific log4j-1.2.17 version for almost three years now (compare dependencies
in [2] and [3]). That is the last version of log4j with the log4j:log4j maven
coordinates.

> hystrix-dashboard.noarch: W: dangling-symlink
> /usr/share/webapps/hystrix/hystrix-dashboard/WEB-INF/lib/commons-logging.jar
> /usr/share/java/commons-logging.jar
> hystrix-dashboard.noarch: W: dangling-symlink
> /usr/share/webapps/hystrix/hystrix-dashboard/WEB-INF/lib/httpcore.jar
> /usr/share/java/httpcomponents/httpcore.jar
> hystrix-dashboard.noarch: W: dangling-symlink
> /usr/share/webapps/hystrix/hystrix-dashboard/WEB-INF/lib/slf4j-api.jar
> /usr/share/java/slf4j/slf4j-api.jar

The other target jars do not contain versions, so upgrades of the packages they
are part of do not break the links.

> Is there a python script somewhere installed?
> 
> sh: /usr/bin/python: No such file or directory

Seems to be the bug in [4]. Should not be related to the package.

[1]
https://fedorahosted.org/released/javapackages/doc/#_replacing_jars_with_symlinks_using_xmvn_subst
[2] http://mvnrepository.com/artifact/org.slf4j/slf4j-log4j12/1.7.0
[3] http://mvnrepository.com/artifact/org.slf4j/slf4j-log4j12/1.7.13
[4] https://bugzilla.redhat.com/show_bug.cgi?id=1243292

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]