https://bugzilla.redhat.com/show_bug.cgi?id=1286006 gil cattaneo <puntogil@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #3 from gil cattaneo <puntogil@xxxxxxxxx> --- Summary NON blocking issues: - Packages have proper BuildRequires/Requires on jpackage-utils - Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink) Note: No javadoc subpackage present See: https://fedoraproject.org/wiki/Packaging:Java#Javadoc_installation - update-desktop-database is invoked in %post and %postun if package contains desktop file(s) with a MimeType: entry. Note: desktop file(s) with MimeType entry in logisim See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#desktop- database [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Apache (v2.0)", "GPL (v2 or later)", "Unknown or generated". 2251 files have unknown license. Detailed output of licensecheck in /home/gil/1286006-logisim/licensecheck.txt Please, fix before import: License: ASL 2.0 and GPLv2+ [!]: Requires correct, justified where necessary. [!]: Packages should try to preserve timestamps of original installed files. Please, fix before import Approved -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review