[Bug 1287822] Review Request: origin - OpenShift Open Source Container Management by Red Hat

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1287822



--- Comment #9 from Michael Scherer <misc@xxxxxxxx> ---
- So, there is no license file for the redistribuable clients (since it doesn't
requires anything). Same got for the master rpm, since it doesn't pull the
origin rpm.


- %{_sysconfdir}/openshift  should be maybe marked as %ghost, since that's a
file that would be created by the rpm. 
( in fact, maybe you can just add it always, along a date to deprecate the
symlink in the future )

- I do not understand the use of basename in :
%systemd_post %{basename:%{name}-master.service}

Can you explain ? 

-  %{kube_plugin_path} should be listed as %dir in the %files sdn-ovs section

- %{_datadir}/%{name}/linux/ and others should be marked %dir and owned, If I
am not wrong.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]